Support for android native libraries in plugin #583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ |
|
✅ |
| this.$logger.info("Generate build.xml for %s", targetDir); | ||
| this.runAndroidUpdate(targetDir, targetSdk).wait(); | ||
|
|
||
| let lines = this.$fs.readText(projProp, "utf-8").wait().split(os.EOL); |
There was a problem hiding this comment.
I think the correct spelling of encoding is "utf8", see https://nodejs.org/api/fs.html#fs_fs_writefile_filename_data_options_callback
At any rate, can we use the property parser module instead?
Fatme
force-pushed
the
fatme/android-native-libs
branch
from
38e7804 to
97b3208
Compare
|
❌ |
|
run ci |
|
✅ |
Fatme
force-pushed
the
fatme/android-native-libs
branch
from
97b3208 to
3178cf9
Compare
|
✅ |
Fatme
force-pushed
the
fatme/android-native-libs
branch
from
3178cf9 to
48c299a
Compare
|
✅ |
| return (() => { | ||
| let editor = this.createEditor().wait(); | ||
| let i = 1; | ||
| while (editor.get(this.buildKeyName(key, i))) { |
|
When plugin is added before platform, on |
| let libRefExists = _.any(references, r => path.normalize(r.path) === path.normalize(referencePath)); | ||
| if(libRefExists) { | ||
| this.removeFromPropertyList("android.library.reference", referencePath).wait(); | ||
| } |
There was a problem hiding this comment.
consider adding else with logger.error("Could not find.....") as it will be easier for debugging
Fatme
force-pushed
the
fatme/android-native-libs
branch
from
48c299a to
df943b1
Compare
|
✅ |
Fatme
force-pushed
the
fatme/android-native-libs
branch
from
df943b1 to
23577ef
Compare
|
✅ |
Fatme
force-pushed
the
fatme/android-native-libs
branch
from
23577ef to
706015d
Compare
|
✅ |
|
👍 |
| let i = 1; | ||
| let currentValue: any; | ||
| while (currentValue = editor.get(this.buildKeyName(key, i))) { | ||
| if (currentValue.toLowerCase() === valueLowerCase) { |
There was a problem hiding this comment.
some indentation issues maybe... The if does not look on its place
|
👍 I have some comments and questions, but no merge-stoppers :) |
Fatme
force-pushed
the
fatme/android-native-libs
branch
from
706015d to
efba2b1
Compare
|
✅ |
Fatme
pushed a commit
that referenced
this pull request
Jul 6, 2015
Support for android native libraries in plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be merged after this PR - telerik/mobile-cli-lib#368
#510